Use unit bytes(IEC)(decbytes, 1,024 bytes in a kibibyte ) for below 18 metrics(disk and memory related) instead of bytes(SI)(bytes, 1,000 bytes in a kilobyte).
metrics_DeviceCelebornTotalBytes_Value
metrics_DeviceCelebornFreeBytes_Value
metrics_PartitionSize_Value
metrics_ActiveShuffleSize_Value
metrics_NettyMemory_Value
metrics_DiskBuffer_Value
metrics_push_usedHeapMemory_Value
metrics_push_usedDirectMemory_Value
metrics_fetch_usedHeapMemory_Value
metrics_fetch_usedDirectMemory_Value
metrics_replicate_usedHeapMemory_Value
metrics_replicate_usedDirectMemory_Value
metrics_BufferStreamReadBuffer_Value
metrics_SortMemory_Value
metrics_DeviceOSFreeBytes_Value
metrics_DeviceCelebornFreeBytes_Value
metrics_diskBytesWritten_Value
metrics_hdfsBytesWritten_Value
Also apply for 6 jvm metrics
metrics_jvm_memory_heap_init_Value
metrics_jvm_memory_non_heap_init_Value
metrics_jvm_memory_total_init_Value
metrics_jvm_memory_pools_init_Value
metrics_jvm_direct_capacity_Value
metrics_jvm_mapped_capacity_Value
Why are the changes needed?
Some size related metrics use bytes(IEC) and some use bytes(SI).
The main difference between bytes in the International System of Units (SI) and the International Electrotechnical Commission (IEC) is the number of bytes in a kilobyte:
SI: 1,000 bytes in a kilobyte
IEC: 1,024 bytes in a kibibyte
What changes were proposed in this pull request?
Use unit
bytes(IEC)
(decbytes
, 1,024 bytes in a kibibyte ) for below 18 metrics(disk and memory related) instead ofbytes(SI)
(bytes
, 1,000 bytes in a kilobyte).Also apply for 6 jvm metrics
Why are the changes needed?
Some size related metrics use
bytes(IEC)
and some usebytes(SI)
.The main difference between bytes in the International System of Units (SI) and the International Electrotechnical Commission (IEC) is the number of bytes in a kilobyte: SI: 1,000 bytes in a kilobyte IEC: 1,024 bytes in a kibibyte
FYI: https://www.drupal.org/project/drupal/issues/1114538#:~:text=According%20to%20the%20SI%20standard,e.g.%20a%20stick%20of%20RAM.
https://github.com/apache/celeborn/blob/4545cdc401a5274966453fe997f18fce666836f3/assets/grafana/celeborn-dashboard.json#L5636-L5699
Does this PR introduce any user-facing change?
Yes, metrics unit changed.
How was this patch tested?
Not needed, we already use
decbytes
in the dashboard json.