[CELEBORN-1711][TEST] Fix '65535' port is invalid - Githubissues

apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.

https://celeborn.apache.org/

Apache License 2.0

893 stars 361 forks source link

[CELEBORN-1711][TEST] Fix '65535' port is invalid #2901

Closed turboFei closed 1 week ago

turboFei commented 1 week ago

What changes were proposed in this pull request?

Fix flaky test caused by invalid port.

[info] ApiMasterResourceSuite:
[info] org.apache.celeborn.service.deploy.master.http.api.ApiMasterResourceSuite *** ABORTED ***
[info]   java.lang.IllegalArgumentException: '65535' in celeborn.master.http.port is invalid. Invalid port

Why are the changes needed?

The ports range in CelebornConf is [1024, 65535), 65535 is excluded.

https://github.com/apache/celeborn/blob/169b6f6973b2ee5093d91df0d2b573977efdc7ae/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala#L2315-L2324

Does this PR introduce any user-facing change?

No.

How was this patch tested?

GA.

turboFei commented 1 week ago

The invalid port issue happen frequently recently. I plan to merge it and then rebase https://github.com/apache/celeborn/pull/2906 on this, thanks all for the review.