apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
167 stars 88 forks source link

Remove deprecated header for public api #542

Open xuzhenbao opened 1 year ago

xuzhenbao commented 1 year ago

fix #538 1.Remove the deprecated headers used by rsa_spi 2.Remove the deprecated headers used by pubsub_spi 3.Remove the deprecated headers used by conan_test_package

  1. add conan_test_package for rsa_discovery_zeroconf.
codecov-commenter commented 1 year ago

Codecov Report

Merging #542 (d84bf74) into master (c0666d0) will decrease coverage by 0.03%. The diff coverage is 33.33%.

:exclamation: Current head d84bf74 differs from pull request most recent head cdc77e0. Consider uploading reports for the commit cdc77e0 to get more accurate results

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   77.43%   77.41%   -0.03%     
==========================================
  Files         225      225              
  Lines       34532    34523       -9     
==========================================
- Hits        26739    26725      -14     
- Misses       7793     7798       +5     
Impacted Files Coverage Δ
...bsub/pubsub_admin_udp_mc/src/pubsub_udpmc_common.c 0.00% <0.00%> (ø)
...sub_admin_udp_mc/src/pubsub_udpmc_topic_receiver.c 0.00% <0.00%> (ø)
...lizer_avrobin/src/pubsub_avrobin_serializer_impl.c 5.65% <0.00%> (+0.01%) :arrow_up:
...b/pubsub_utils/src/pubsub_serialization_provider.c 67.08% <ø> (ø)
...ubsub/pubsub_utils/src/pubsub_serializer_handler.c 93.47% <ø> (ø)
...te_service_admin_shm_v2/rsa_shm/src/rsa_shm_impl.c 96.89% <ø> (ø)
...ubsub_admin_udp_mc/src/pubsub_udpmc_topic_sender.c 57.31% <20.00%> (+0.76%) :arrow_up:
...ubsub_serializer_json/src/pubsub_serializer_impl.c 35.53% <46.66%> (-0.11%) :arrow_down:
...ervices/rsa_rpc_json/src/rsa_json_rpc_proxy_impl.c 96.75% <100.00%> (ø)
libs/framework/src/module.c 74.36% <100.00%> (+0.72%) :arrow_up:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

PengZheng commented 1 year ago

I agree with @pnoltes. Let's merge it for 3.0.0.

PengZheng commented 1 year ago

Now it is good time to re-attempt this PR. @xuzhenbao

PengZheng commented 8 months ago

Given that pubsub has already been removed, it this PR already done? @xuzhenbao

xuzhenbao commented 8 months ago

Given that pubsub has already been removed, it this PR already done? @xuzhenbao

Thanks for the reminder. Maybe I need to plan a time to update this PR.