codecov-commenter
commented
1 year ago Codecov Report
Merging #553 (e7b53f5) into master (fc18c65) will increase coverage by
0.22%. The diff coverage is99.70%.:exclamation: Current head e7b53f5 differs from pull request most recent head c907d6a. Consider uploading reports for the commit c907d6a to get more accurate results
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 77.43% 77.66% +0.22%
==========================================
Files 226 229 +3
Lines 34639 34928 +289
==========================================
+ Hits 26824 27126 +302
+ Misses 7815 7802 -13 | Impacted Files | Coverage Δ | |
|---|---|---|
| libs/framework/src/dm_dependency_manager_impl.c | 79.47% <93.33%> (-0.26%) |
:arrow_down: |
| bundles/logging/log_admin/src/celix_log_admin.c | 99.76% <100.00%> (+0.02%) |
:arrow_up: |
| bundles/logging/log_helper/src/celix_log_helper.c | 100.00% <100.00%> (ø) |
|
| libs/framework/src/framework.c | 77.71% <100.00%> (+0.24%) |
:arrow_up: |
| libs/rcm/src/celix_capability.c | 100.00% <100.00%> (ø) |
|
| libs/rcm/src/celix_requirement.c | 100.00% <100.00%> (ø) |
|
| libs/rcm/src/celix_resource.c | 100.00% <100.00%> (ø) |
... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR fixes an issue that the during bundle install a warning is printed that a bundle cannot be refreshed.
I removed the fw_bundleRefresh call, because it was only used in bundle uninstall and I see no reason to then refresh the bundle.
Also solves a issue that the dm infos gathering for also done for not active bundles.