apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
162 stars 86 forks source link

Feature/556 osgi uninstall #569

Closed PengZheng closed 1 year ago

PengZheng commented 1 year ago

To fix #556, #557, part of #561, and #563, this PR introduces:

I plan to add thorough whitebox tests to the life cycle layer and the module layer after this merged and #522 implemented.

codecov-commenter commented 1 year ago

Codecov Report

Merging #569 (eec55b4) into master (ab2cc5e) will increase coverage by 0.20%. The diff coverage is 80.84%.

:exclamation: Current head eec55b4 differs from pull request most recent head 58a3c3b. Consider uploading reports for the commit 58a3c3b to get more accurate results

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   78.08%   78.28%   +0.20%     
==========================================
  Files         229      230       +1     
  Lines       35016    35013       -3     
==========================================
+ Hits        27341    27409      +68     
+ Misses       7675     7604      -71     
Impacted Files Coverage Δ
...sub_topology_manager/src/pubsub_topology_manager.c 52.38% <0.00%> (-0.45%) :arrow_down:
libs/framework/src/bundle.c 72.01% <0.00%> (+2.35%) :arrow_up:
libs/framework/src/bundle_archive.c 100.00% <ø> (+3.37%) :arrow_up:
libs/framework/src/bundle_context.c 80.02% <25.00%> (-0.19%) :arrow_down:
libs/framework/src/framework.c 81.45% <82.35%> (+3.78%) :arrow_up:
...framework/src/framework_bundle_lifecycle_handler.c 86.27% <91.66%> (+30.60%) :arrow_up:
bundles/shell/shell/src/query_command.c 84.00% <100.00%> (ø)
bundles/shell/shell/src/std_commands.c 100.00% <100.00%> (ø)
bundles/shell/shell/src/unload_command.c 100.00% <100.00%> (ø)
libs/framework/src/bundle_revision.c 100.00% <100.00%> (+27.08%) :arrow_up:
... and 2 more

... and 6 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

PengZheng commented 1 year ago

Could you help review this? @pnoltes I intend to merge this before more work (and tests) on module/life cycle layer.

pnoltes commented 1 year ago

Could you help review this? @pnoltes I intend to merge this before more work (and tests) on module/life cycle layer.

Yes, happily. Please allow me a few days to find the time to thoroughly review this.