push Streams library can build failed

[tonychen0924]

When I build ush Streams library in ubuntu22.04 and cmake version 3.22.1 , it will compiled faied , forward info: CMake Error at CMakeLists.txt:19 (celix_subproject): Unknown CMake command "celix_subproject". I also check elso lib : etcdlib and Promises , there CMakeLists.txt defined "if (NOT COMMAND celix_subproject)" logic , but Streams do not have .

And I want to know this lib if is necessary to build example case , such as hello world

[PengZheng]

PushStreams depends on Promises.

Instead of making PushStreams a standalone project (actually we can't), we can combine etcdlib/Promises/PushStreams into Celix, and make the framework optional, so that we can opt to build etcdlib/Promises/Promises+PushStreams alone.

Also automatic dependency deduction can be easily implemented at Conan level. That means if you want PushStreams, Promises will be automatically built for you.

[pnoltes]

I agree. IMO this means:

• Adjusted the cmake files to make the framework and utils lib optional and ensure that bundles can only be build if framework is build
• Introduce a GitHub workflow that only builds etcd, promises and push streams to ensure those libs can be build without the rest of Celix
• Update the building documentation, etcdlib and promises documentation to reflect this.

[tonychen0924]

Thank you very much for your answer . But when I build example direcotry process , such as helloword , it will cmake error : Unknown CMake command "add_celix_bundle". Why ? I mistakenly thought it was pushStreams reason .

[PengZheng]

Thank you very much for your answer . But when I build example direcotry process , such as helloword , it will cmake error : Unknown CMake command "add_celix_bundle". Why ? I mistakenly thought it was pushStreams reason .

Does #577 fix your problem?

[PengZheng]

The OP's issue has been fixed.