Closed PengZheng closed 1 year ago
Merging #589 (e492c63) into master (8bcac0f) will increase coverage by
0.03%
. The diff coverage is100.00%
.:exclamation: Current head e492c63 differs from pull request most recent head c789b89. Consider uploading reports for the commit c789b89 to get more accurate results
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 78.50% 78.54% +0.03%
==========================================
Files 234 234
Lines 35389 35431 +42
==========================================
+ Hits 27782 27829 +47
+ Misses 7607 7602 -5
Files Changed | Coverage Δ | |
---|---|---|
libs/framework/src/celix_launcher.c | 92.35% <100.00%> (ø) |
... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR fixes #579 by implementing automatic dependency deduction among components within the Celix package.
Now we can specify only what we need, and a minimal Conan package with corresponding feature (and its internal dependencies, but nothing more) will be built for us automatically.
For example, if we only need PushStreams, the following snippet should be enough for any downstream project:
Or we can create a minimal Conan package with only PushStreams and Promises support by the following command line:
To this end:
build_
options default to beFalse
. Please note that CMake caches' defaults are not changed.build_
option. This is necessary to fix https://github.com/apache/celix/actions/runs/5560191654/jobs/10156995210CodeCoverage.cmake
has been updated to exclude them from Coverage statistics.Celix::celix
dummy target is introduced. Now all components can be turned off, which will result in empty package. Without this target,install(TARGETS ...)
will report unknown export "celix" error. Note that creating an empty package is the fastest way of publishing a new conan package (without actually building anything). In my day job, I normally publish package this way (CI has already guaranteed that the package can be built correctly).build_
option enabled.conan_test_package
has been updated to discard usage of deprecated headers, and more tests are added.Documentation has not been updated to reflect the above. We may need more usage experience.
@xuzhenbao I noticed if
mdnsresponder/1790.80.10
were used, tests failed. Is that normal?