apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
162 stars 86 forks source link

Unnecessary bundle copy when building bundle container #597

Open PengZheng opened 1 year ago

PengZheng commented 1 year ago

Originally, the copying of bundles was tracked with a timestamp file, in combination with a CMake add_custom_command. However, attempts to resolve the problem with the add_custom_command proved unsuccessful, leading me to replace it with add_custom_target.

In my opinion, a custom target is less than ideal, as a custom target dependency always triggers whenever a target is built. A comparison of the time to run make -j when nothing has changed demonstrated that on my systems, it took twice as long (albeit still under 1 second).

_Originally posted by @pnoltes in https://github.com/apache/celix/pull/594#issue-1820929811