search

apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
165 stars 86 forks source link

Hotfix/LDAP filter for Version Range #625

Closed PengZheng closed 1 year ago

PengZheng commented 1 year ago

I was surprised to find that our dm_exmaple remained broken (dm wtf gives phase2b) though #432 has already been fixed. It turns out that the culprit is version range LDAP filter which ignores the qualifier term of a version.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@27a2539). Click here to learn what that means. The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master     #625   +/-   ##
=========================================
  Coverage          ?   81.58%           
=========================================
  Files             ?      260           
  Lines             ?    34680           
  Branches          ?        0           
=========================================
  Hits              ?    28293           
  Misses            ?     6387           
  Partials          ?        0
Files Changed Coverage Δ
bundles/shell/shell/src/dm_shell_list_command.c 0.00% <0.00%> (ø)
libs/utils/src/version_range.c 80.79% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more