Closed PengZheng closed 10 months ago
Merging #654 (da65fcf) into master (be8a413) will decrease coverage by
0.08%
. The diff coverage is100.00%
.:exclamation: Current head da65fcf differs from pull request most recent head 4e15eaf. Consider uploading reports for the commit 4e15eaf to get more accurate results
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 81.68% 81.60% -0.08%
==========================================
Files 260 260
Lines 34675 34680 +5
==========================================
- Hits 28323 28300 -23
- Misses 6352 6380 +28
Files Changed | Coverage Δ | |
---|---|---|
libs/framework/src/framework.c | 85.04% <100.00%> (-0.20%) |
:arrow_down: |
... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
LGTM (tested locally and the test failure is solved)
So I will close this, and send another workaround PR for cxx_remote_services instead.
IMHO, we should find out why 6bb8de5 breaks test_cxx_remote_services_integration, there seems something very unusual happens inside C++ RSA.
TestExportImportRemoteServiceFactory
seems buggy as explained here.This PR can serve as a stop gap. The more involved design issue of
TestExportImportRemoteServiceFactory
should be addressed later.