codecov-commenter
commented
9 months ago Codecov Report
Merging #665 (1e74897) into master (f8e95a5) will decrease coverage by
1.33%. The diff coverage is100.00%.:exclamation: Current head 1e74897 differs from pull request most recent head ad8004f. Consider uploading reports for the commit ad8004f to get more accurate results
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
- Coverage 83.00% 81.67% -1.33%
==========================================
Files 252 252
Lines 32789 32656 -133
==========================================
- Hits 27215 26672 -543
- Misses 5574 5984 +410 | Files | Coverage Δ | |
|---|---|---|
| ...es/rsa_spi/include/celix/rsa/EndpointDescription.h | 90.90% <ø> (ø) |
|
| libs/framework/include/celix/Bundle.h | 100.00% <ø> (ø) |
|
| libs/framework/include/celix/BundleContext.h | 100.00% <ø> (ø) |
|
| libs/framework/include/celix/FrameworkUtils.h | 100.00% <ø> (ø) |
|
| libs/framework/include/celix/ServiceRegistration.h | 96.49% <ø> (-0.15%) |
:arrow_down: |
| ...amework/include/celix/ServiceRegistrationBuilder.h | 100.00% <ø> (ø) |
|
| libs/framework/include/celix/TrackerBuilders.h | 100.00% <ø> (ø) |
|
| libs/framework/include/celix/Trackers.h | 91.24% <ø> (-0.76%) |
:arrow_down: |
| libs/framework/include/celix/UseServiceBuilder.h | 100.00% <ø> (ø) |
|
| libs/utils/include/celix/Filter.h | 100.00% <ø> (ø) |
|
| ... and 2 more |
... and 9 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR removes the C++17 string_view support from the
utilsandframeworklibraries. This is task in #509.The removal ensures easier C++ support, as the string_view integration required numerous
#ifdefdirectives to guarantee API compatibility with C++14. It also mandated that we compile and run tests with both C++14 and C++17 flags.