search

apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
158 stars 84 forks source link

Feature/coverity fix #709

Closed PengZheng closed 6 months ago

PengZheng commented 6 months ago

This PR fixes a use-after-free in error handing of http_admin and removes ip_utils, whose API is deprecated and no longer used in the Celix project.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ab7b7af) 88.33% compared to head (4df554c) 88.37%.

:exclamation: Current head 4df554c differs from pull request most recent head 780e873. Consider uploading reports for the commit 780e873 to get more accurate results

Files Patch % Lines
...undles/http_admin/http_admin/src/websocket_admin.c 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #709 +/- ## ========================================== + Coverage 88.33% 88.37% +0.03% ========================================== Files 215 214 -1 Lines 24500 24429 -71 ========================================== - Hits 21643 21589 -54 + Misses 2857 2840 -17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rlenferink commented 6 months ago

About the ip_utils, I noticed Pepijn is refactoring things on that, see: https://github.com/apache/celix/commit/01b3af14dbf197239b7403e72cbb538e461a4099

Isn’t the potential use case for that the RSA @pnoltes ?

PengZheng commented 6 months ago

If ip_utils is still needed, I will revert the remove and fix the newly reported coverity issues.

pnoltes commented 6 months ago

About the ip_utils, I noticed Pepijn is refactoring things on that, see: 01b3af1

Isn’t the potential use case for that the RSA @pnoltes ?

Correct I refactored the IP utils and indeed I also kept the IP utils so that they maybe can be used in the RSA implementations.

@PengZheng If the refactored IP util functions in #711 are good enough I think we could keep them for now.

PengZheng commented 6 months ago

Let's fix ip_utils in #711.