Closed xuzhenbao closed 7 months ago
Attention: 102 lines
in your changes are missing coverage. Please review.
Comparison is base (
70548d6
) 88.85% compared to head (e48e5ed
) 89.32%. Report is 12 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@pnoltes
I have updated the PR, it includes the following changes:
1.Move the work of exporting dynamic IP endpoints to the Topology Manager, the dynamic IP endpoints contain the following specific properties.
The endpoint listener service of Discovery adds the property celix.rsa.discovery.interface.specific.endpoints.support, which indicates whether DISCOVERY supports dynamic IP filling based on the network interface name.
The RSA service adds the property celix.rsa.dynamic.ip.support, which indicates whether RSA supports dynamic IP. When the celix.rsa.dynamic.ip.support property is true, the Topology Manager should generate dynamic IP endpoints based on the registration exported by RSA, and notify these endpoints to the DISCOVERY implementation that supports dynamic IP.
Add configuration property CELIX_RSA_INTERFACES_OFPORT
Add the Facility of libcurl error codes, which is used to distinguish between http status code (CELIX_FACILITY_HTTP) and libcurl error codes in rsa_dfi
Add CELIX_RSA prefix for constants in the rsa_spi
celix.rsa.ip.addresses currently uses a comma-separated string, and it will use a string array (It depends on https://github.com/apache/celix/issues/674)
Topology Manager and RSA_DFI still leave some deprecated interfaces usage, and the related code is planned to be cleaned up in other PRs.
7. nd it will use a string array (
Thanks for the trigger, I will try to find some time to review this in the coming days.
Fix some issues of #690 and improve
zeroconf_discovery
.1.Improve
zeroconf_discovery
and add hostname resolving mechanism. 2.Rename remote service bundles. 3.Add zeroconf configuration type forrsa_dfi
. 4.Addremote.configs.supported
property forremote_service_admin
service.