search

apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
158 stars 84 forks source link

Hotfix/conan private dep #735

Closed PengZheng closed 4 months ago

PengZheng commented 4 months ago

Fix linker error caused by private linking of transitive dependencies. Check https://github.com/conan-io/conan/issues/7192 for more information

Compared with previous workaround, this fix does not ignore unresolved symbols in shared libraries and thus is more robust.

I encountered a GitHub Action error which does not reproduce in my local machine: https://github.com/conan-io/conan/issues/15818

Next time I will squash these debugging commits before merging them into trunk.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.63%. Comparing base (0601f95) to head (acabf59).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #735 +/- ## ========================================== + Coverage 89.58% 89.63% +0.05% ========================================== Files 216 216 Lines 25413 25413 ========================================== + Hits 22765 22779 +14 + Misses 2648 2634 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.