search

apache / celix

Apache Celix is a framework for C and C++14 to develop dynamic modular software applications using component and in-process service-oriented programming.
https://celix.apache.org/
Apache License 2.0
158 stars 84 forks source link

Event admin #738

Closed xuzhenbao closed 3 months ago

xuzhenbao commented 3 months ago

This PR implements a local event admin and maps celix-framework-event to event-admin-event. See the PR's README.md for details.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.96907% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 89.88%. Comparing base (d46d983) to head (1f1ba1f).

Files Patch % Lines
.../event_admin/event_admin/src/celix_event_adapter.c 97.56% 4 Missing :warning:
...es/event_admin/event_admin/src/celix_event_admin.c 99.26% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #738 +/- ## ========================================== + Coverage 89.58% 89.88% +0.30% ========================================== Files 216 222 +6 Lines 25413 26092 +679 ========================================== + Hits 22765 23454 +689 + Misses 2648 2638 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pnoltes commented 3 months ago

Very nice addition for Apache Celix :). I had a short look into the event_admin_api and this looks good; Clean api and well documented. I will try to find some time this week and next week to more thoroughly review this.