Closed pnoltes closed 3 months ago
Attention: Patch coverage is 93.61702%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 89.52%. Comparing base (
d46d983
) to head (1c4b4de
).
Files | Patch % | Lines |
---|---|---|
bundles/shell/shell/src/help_command.c | 88.88% | 2 Missing :warning: |
libs/framework/src/bundle_context.c | 96.55% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR simplifies the implementation of
celix_bundleContext_useService*
functions to somewhat reduce the complexity of the framework library.The updated
celix_bundleContext_useService*
functions now reuse thecelix_bundleContext_trackServices
function andcelix_bundleContext_useTrackedService*
functions, which has several consequences:celix_bundleContext_useService*
function will lead to a new, short-lived, tracker ID.In my opinion, these changes are acceptable because the primary, and in my opinion only, use case for the
useService*
functions/methods is in test code. As a result, this PR also updates theuseService*
functions/methods documentation to clarify their intended use case. I also think that we do not need to deprecate the useService* functions/methods, ideally they should be moved to a "test-code-only" header but for now I think this is good enough.Additionally, the usage of
celix_bundleContext_useService
in the help shell command has been refactored to direct service tracker usage.