Cherry-pick VACUUM stats & Vacuum progress related commits.

[reshke]

Cherry-pick some GPDB commits.

This is part 1 of my native Yezzey support for CBDB plan https://github.com/yezzey-gp/yezzey/issues/40#issuecomment-2321149779

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 10 committers have signed the CLA.

:white_check_mark: reshke
:x: haolinw
:x: soumyadeep2007
:x: linxuh
:x: AJR-VMware
:x: Stolb27
:x: l-wang
:x: kainwen
:x: bmdoil
:x: huansong
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[reshke]

UPD: cherry-pick a6fdc27246e46bf3b72d43420c1454a37e68e273 from gp7 to fix incorrect regression test results

[lss602726449]

Thanks for your Merge Request. I think We'd better revert the last commit which have been merged and squash the last two commit (refac and https://github.com/cloudberrydb/cloudberrydb/pull/611/commits/993d11ecc0a81b09977fc91e06302b0f5851923a) together.

[reshke]

Thanks for your Merge Request. I think We'd better revert the last commit which have been merged and squash the last two commit (refac and 993d11e) together.

Hi, many thanks for your review. did exacly as you suggested.

[reshke]

Applied all review comments as suggested

[ostinru]

hm... it seems that make is broken (for me) after this patch...

 > [cloudberry 8/8] RUN locale-gen en_US.utf8 \
 && ./configure --with-perl --with-python --with-libxml --with-gssapi --prefix=/usr/local/gpdb_src > /dev/null \
 && make -j8 > /dev/null \
 && make -j8 install > /dev/null

0.379 Generating locales (this might take a while)...
0.381   en_US.UTF-8... done
1.244 Generation complete.
29.97 appendonlyam.c: In function 'appendonly_insert':
29.98 appendonlyam.c:3052:9: error: unused variable 'firstSequence' [-Werror=unused-variable]
29.98  3052 |   int64 firstSequence = GetFastSequences(aoInsertDesc->segrelid,
29.98       |         ^~~~~~~~~~~~~
30.38 cc1: all warnings being treated as errors
30.38 make[4]: *** [<builtin>: appendonlyam.o] Error 1
30.38 make[4]: *** Waiting for unfinished jobs....
30.64 make[3]: *** [../../../src/backend/common.mk:39: appendonly-recursive] Error 2
30.64 make[3]: *** Waiting for unfinished jobs....
31.84 make[2]: *** [common.mk:39: access-recursive] Error 2
31.84 make[2]: *** Waiting for unfinished jobs....
34.40 make[1]: *** [Makefile:44: all-backend-recurse] Error 2
34.40 make: *** [GNUmakefile:11: all-src-recurse] Error 2

[reshke]

hm... it seems that make is broken (for me) after this patch...

 > [cloudberry 8/8] RUN locale-gen en_US.utf8 \
 && ./configure --with-perl --with-python --with-libxml --with-gssapi --prefix=/usr/local/gpdb_src > /dev/null \
 && make -j8 > /dev/null \
 && make -j8 install > /dev/null

0.379 Generating locales (this might take a while)...
0.381   en_US.UTF-8... done
1.244 Generation complete.
29.97 appendonlyam.c: In function 'appendonly_insert':
29.98 appendonlyam.c:3052:9: error: unused variable 'firstSequence' [-Werror=unused-variable]
29.98  3052 |   int64 firstSequence = GetFastSequences(aoInsertDesc->segrelid,
29.98       |         ^~~~~~~~~~~~~
30.38 cc1: all warnings being treated as errors
30.38 make[4]: *** [<builtin>: appendonlyam.o] Error 1
30.38 make[4]: *** Waiting for unfinished jobs....
30.64 make[3]: *** [../../../src/backend/common.mk:39: appendonly-recursive] Error 2
30.64 make[3]: *** Waiting for unfinished jobs....
31.84 make[2]: *** [common.mk:39: access-recursive] Error 2
31.84 make[2]: *** Waiting for unfinished jobs....
34.40 make[1]: *** [Makefile:44: all-backend-recurse] Error 2
34.40 make: *** [GNUmakefile:11: all-src-recurse] Error 2

Thanks for your feedback! will take a look soon

[reshke]

hm... it seems that make is broken (for me) after this patch...

 > [cloudberry 8/8] RUN locale-gen en_US.utf8 \
 && ./configure --with-perl --with-python --with-libxml --with-gssapi --prefix=/usr/local/gpdb_src > /dev/null \
 && make -j8 > /dev/null \
 && make -j8 install > /dev/null

0.379 Generating locales (this might take a while)...
0.381   en_US.UTF-8... done
1.244 Generation complete.
29.97 appendonlyam.c: In function 'appendonly_insert':
29.98 appendonlyam.c:3052:9: error: unused variable 'firstSequence' [-Werror=unused-variable]
29.98  3052 |   int64 firstSequence = GetFastSequences(aoInsertDesc->segrelid,
29.98       |         ^~~~~~~~~~~~~
30.38 cc1: all warnings being treated as errors
30.38 make[4]: *** [<builtin>: appendonlyam.o] Error 1
30.38 make[4]: *** Waiting for unfinished jobs....
30.64 make[3]: *** [../../../src/backend/common.mk:39: appendonly-recursive] Error 2
30.64 make[3]: *** Waiting for unfinished jobs....
31.84 make[2]: *** [common.mk:39: access-recursive] Error 2
31.84 make[2]: *** Waiting for unfinished jobs....
34.40 make[1]: *** [Makefile:44: all-backend-recurse] Error 2
34.40 make: *** [GNUmakefile:11: all-src-recurse] Error 2

Does this PR make a fix for you https://github.com/cloudberrydb/cloudberrydb/pull/674 ?

[ostinru]

thanks! Build & test from main branch works fine now.