apache / cloudberry

One advanced and mature open-source MPP (Massively Parallel Processing) database. Open source alternative to Greenplum Database.
https://cloudberry.apache.org
Apache License 2.0
430 stars 104 forks source link

Fix ExplainNode forgetting to set sname for node 'T_TupleSplit' #629

Closed fanfuxiaoran closed 2 months ago

fanfuxiaoran commented 2 months ago

When node is 'T_TupleSplit' , the sname for it forgotten to set, then the explain command will fail. Just fix it

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

my-ship-it commented 2 months ago

Please add a description?

avamingli commented 2 months ago

When node is 'T_TupleSplit' , the sname for it forgotten to set, then the explain command will fail.

Add the cases to test?

fanfuxiaoran commented 2 months ago

When node is 'T_TupleSplit' , the sname for it forgotten to set, then the explain command will fail.

Add the cases to test?

Hard to add cases to cover each type of plannode. Maybe enable the autoexplain extension can help.