apache / cloudberry

One advanced and mature open-source MPP (Massively Parallel Processing) database. Open source alternative to Greenplum Database.
https://cloudberry.apache.org
Apache License 2.0
430 stars 104 forks source link

UFileClose needs a return value. #640

Closed gongxun0928 closed 1 month ago

gongxun0928 commented 1 month ago

The close function may have an error and return a return value which less than 0, so UFileClose also needs a return value. The external system checks the return value to determine whether an error has occurred. If an error occurs, the error information is obtained through UFileGetLastError.

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

wenchaozhang-123 commented 1 month ago

Need also to change the fileam->close function return type?