Open yihong0618 opened 1 week ago
Hi @yihong0618, thank you! There is already a PR #696 for the link changes. Please feel free to rebase your commit once #696 is merged.
BTW, welcome to take the git commit template to amend your commit title and body. Thanks again!
@tuhaihe the issue created is dead in cloudberry it will link a 404 page, maybe we can merge this two pull requests when click these things it will be 404...
@tuhaihe the issue created is dead in cloudberry it will link a 404 page, maybe we can merge this two pull requests
Agreed. Welcome to rebase to trigger the CI (now can use the tag ‘skip ci ‘ to skip the checks) then merge it.
Hi @yihong0618 welcome to resolve the conflicts.
Also please amend your commit messages per the template - https://github.com/apache/cloudberry/blob/main/.gitmessage, thanks.
done
Hi @edespino have added the tag skip ci
to the PR title, but it seems that we still cannot skip the build. FYI.
@tuhaihe - I believe the [skip ci]
will work but it has be in the PR title when the PR is created. Please give it a try with the next PR which does not need a build. You can also test it with a draft PR and then close it.
fix #ISSUE_Number
Change logs
As cloudberry the org changed to apache now, most of the links can redirect but for the discuss such as orgs/cloudberry/discuss can not, this PR fix that case. you can try: link dead: https://github.com/orgs/cloudberrydb/discussions/categories/proposal link fixed: url: https://github.com/apache/cloudberrydb/discussions/categories/proposal
for the case it may graduate from apache some day so keep the urls can redirect first.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳