Fix maybe uniniatilzed access of variable

reshke commented 1 week ago

tag.c: In function ‘AddTagDescriptions’:
tag.c:507:20: error: ‘value_cell’ may be used uninitialized [-Werror=maybe-uninitialized]
  507 |                 if (value_cell || isnull)
      |                    ^
tag.c:473:34: note: ‘value_cell’ was declared here
  473 |                 ListCell        *value_cell;
      |                                  ^~~~~~~~~~
cc1: all warnings being treated as errors

Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

yjhjstz commented 6 days ago

@wenchaozhang-123 help take a look.

reshke commented 4 days ago

I don't understand why CI fails

tuhaihe commented 4 days ago

I don't understand why CI fails

Hi @reshke the CI is still in the process of restoration. Be patient to wait for a few days.

wenchaozhang-123 commented 3 days ago

Please squash the commits to one.

tuhaihe commented 1 day ago

I don't understand why CI fails

Hi @reshke the CI is still in the process of restoration. Be patient to wait for a few days.

Hi @reshke now welcome to try to force push again, then should can trigger the new CI checks.

reshke commented 1 day ago

Some problems with build template


Error: The template is not valid. .github/workflows/build-cloudberry.yml (Line: 190, Col: 19): Unexpected value '',.github/workflows/build-cloudberry.yml (Line: 191, Col: 19): Unexpected value ''

reshke commented 1 day ago

Some problems with build template


Error: The template is not valid. .github/workflows/build-cloudberry.yml (Line: 190, Col: 19): Unexpected value '',.github/workflows/build-cloudberry.yml (Line: 191, Col: 19): Unexpected value ''

looks like env.DOCKERHUB_USER/env.DOCKERHUB_TOKEN substitution fails.

edespino commented 1 day ago

Sorry for the inconvenience. I have a PR in flight which will remove the secrets dependency and unblock the builds.

https://github.com/apache/cloudberry/pull/719

edespino commented 1 day ago

If I could get a review of https://github.com/apache/cloudberry/pull/719, it will help getting builds unblocked.

apache / cloudberry