apache / cloudstack-cloudmonkey

Apache Cloudstack Cloudmonkey
Apache License 2.0
91 stars 60 forks source link

associatednetworkid= does not autocomplete #118

Closed alexandremattioli closed 1 year ago

alexandremattioli commented 1 year ago

When creating a shared network using an offering which has the SpecifyVLAN option set the associatednetworkid= should be able to autocomplete with the networks of that domain/account

borisstoyanov commented 1 year ago

@alexandremattioli can you give an example prompt with cmk please. From what I see you want it to look for associatednetworkid, but there is no such API listAssociatedNetworks, so I think this improvement is not achievable at the moment?

alexandremattioli commented 1 year ago

@borisstoyanov it actually should list just the networks available, so network being created can be associated to one of them. It's just a "list networks"

borisstoyanov commented 1 year ago

@DaanHoogland can this correlate with #72 then?

DaanHoogland commented 1 year ago

yes, @borisstoyanov . it is bot about more intelligent autocompletion. This one to recognise the noun to use a list call for, and the aother one to add more specific arguments to the list command.

borisstoyanov commented 1 year ago

@rohityadavcloud advised this could be a small one, he's open to advise the assignee

rohityadavcloud commented 1 year ago

If the default heuristic isn't working, in the autocompletion code we can use a specific API for specific param that fixes this issue. cc @nvazquez there are existing examples with list templates etc I think in the codebase.

borisstoyanov commented 1 year ago

fixed with #133