apache / cloudstack-cloudmonkey

Apache Cloudstack Cloudmonkey
Apache License 2.0
91 stars 60 forks source link

Do not encode asterisks on requests #130

Closed nvazquez closed 1 year ago

nvazquez commented 1 year ago

Fixes: #128

Incorporating changes from: https://github.com/apache/cloudstack-go/pull/52

(localcloud) 🐱 > update configuration name=consoleproxy.url.domain value=*.example.org
{
  "configuration": {
    "category": "Console Proxy",
    "description": "Console proxy url domain",
    "isdynamic": false,
    "name": "consoleproxy.url.domain",
    "value": "*.example.org"
  }
}

Passes the asterisk correctly and is not encoded

2023-04-10 11:18:56,946 DEBUG [c.c.a.ApiServlet] (qtp2129144075-16:ctx-b28b0063) (logid:44b8995f) ===START===  10.0.3.251 -- GET  apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=updateConfiguration&name=consoleproxy.url.domain&response=json&value=*.example.org&signature=00AgwiNGweTliSZKGFyGIHUGSyM%3D
borisstoyanov commented 1 year ago

Thanks @rohityadavcloud and @nvazquez will test it manually and merge it