apache / cloudstack-kubernetes-provider

Apache Cloudstack Kubernetes Provider
https://cloudstack.apache.org/
Apache License 2.0
38 stars 21 forks source link

Allow case insensitive vm names while creating lb rules #41

Closed davidjumani closed 1 year ago

davidjumani commented 2 years ago

In kubernetes, node names are in lower case but a VM can have an upper case name in cloudstack This can cause issues mapping kuberenetes nodes to cloudstack VMs Fixes this issue

kiwiflyer commented 1 year ago

@DaanHoogland Is it too late to pull this in for 4.18?

weizhouapache commented 1 year ago

@kiwiflyer cloudstack-kubernetes-provider is a standalone project, which has different release cycle as cloudstack

kiwiflyer commented 1 year ago

@kiwiflyer cloudstack-kubernetes-provider is a standalone project, which has different release cycle as cloudstack

Got it, thanks!

rohityadavcloud commented 1 year ago

LGTM @davidjumani what do we need to merge this?

davidjumani commented 1 year ago

Just click the merge button :)

rohityadavcloud commented 1 year ago

I meant to say, in terms of testing and review @davidjumani I'll merge this however as changes make sense to me and Build has passed.

davidjumani commented 1 year ago

My bad @rohityadavcloud I had tested this myself and verified the fix