search

apache / cloudstack-primate

Primate - modern role-base progressive UI for Apache CloudStack
https://cloudstack.apache.org/
Apache License 2.0
39 stars 37 forks source link

Handle redirect to sub menu when click parent menu #876

Closed utchoang closed 3 years ago

utchoang commented 3 years ago

Fixes #805 @rhtyd cc @svenvogel Please review it. Thanks.

davidjumani commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3701)

rohityadavcloud commented 3 years ago

I still see the same old behaviour @utchoang can you check the test/QA env.

utchoang commented 3 years ago

@rhtyd Currently, it only activity for the tablet and mobile mode.

rohityadavcloud commented 3 years ago

@utchoang can you do this for desktop as well?

utchoang commented 3 years ago

@blueorangutan package

davidjumani commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3757)

rohityadavcloud commented 3 years ago

Thanks @utchoang I tested does not seem to work, is there something I'm missing (I'm expecting the VM to be selected/open when I click compute)?

utchoang commented 3 years ago

@rhtyd Sorry about my mistake. Please review it again. Thanks.

rohityadavcloud commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

utchoang commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3761)

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3762)

rohityadavcloud commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3763)

rohityadavcloud commented 3 years ago

Tested few screens for mobile and desktop - lgtm.

davidjumani commented 3 years ago

@utchoang It intermittently works on desktops. Just navigate from top to bottom and back up again and sometimes it does not open the first sub-menu. Could you fix it ? Works fine when the menu is condensed but intermittently when fully expanded

utchoang commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3765)

davidjumani commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3768)

rohityadavcloud commented 3 years ago

LGTM, @davidjumani are you lgtm on it for merging?

davidjumani commented 3 years ago

@utchoang Looks like navigation sometimes breaks now if anything other than the first sub-menu item is selected :(

utchoang commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3771)

rohityadavcloud commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3772)

rohityadavcloud commented 3 years ago

LGTM - on latest testing on desktop and mobile; the only case it doesn't work is when you click on right on the nav title (not on the expand button but between the title/label and the right expand button, it expands than open the first child) - still better than what we've now. @davidjumani can you test your cases?

davidjumani commented 3 years ago

@utchoang @rhtyd Works well on mobile and tablet. Clicking the icon / text while on desktop opens the first submenu, so users who'd just like to brows the navbar can click the blank space