search

apache / cloudstack-primate

Primate - modern role-base progressive UI for Apache CloudStack
https://cloudstack.apache.org/
Apache License 2.0
39 stars 37 forks source link

Dont pass account/domainid for upload sslcert in project view #893

Open ravening opened 3 years ago

ravening commented 3 years ago

In project view, we can upload ssl certificate either by using projectid or accountid/domainid combination. Since we are passing all 3 parameters, we cant upload sslcert in project view

Screenshot 2020-12-07 at 14 08 55

davidjumani commented 3 years ago

@blueorangutan package

blueorangutan commented 3 years ago

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented 3 years ago

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/893 (JID-3755)

davidjumani commented 3 years ago

@ravening This will make the form require the user to enter the account as well as domain which is redundant as he's already navigated to the desired account. Instead, would it be better to exclude passing the projectid if the current route contains "account" over at https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L83 ?

ravening commented 3 years ago

@ravening This will make the form require the user to enter the account as well as domain which is redundant as he's already navigated to the desired account. Instead, would it be better to exclude passing the projectid if the current route contains "account" over at https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L83 ?

@davidjumani we don't need to enter anything here. If we are in project view then project id is passed else account/domain will be taken from backend code

If we pass both account and domain in project view then exception is thrown

davidjumani commented 3 years ago

@ravening The account will be taken for the current user but say an admin will have to pass the account and domain while adding a certificate for another account, after having navigated to that account

rohityadavcloud commented 3 years ago

Ping @ravening any update on this?

weizhouapache commented 3 years ago

@ravening @rhtyd @davidjumani can we do like this ? (1) in project view, ssl cert will be uploaded to project account, no matter what current account is. otherwise there is no way to upload ssl cert to a project. (2) in normal view, ssl cert will be uploaded to the current account on web page.