apache / cloudstack-primate

Primate - modern role-base progressive UI for Apache CloudStack
https://cloudstack.apache.org/
Apache License 2.0
39 stars 37 forks source link

Missing of Add IP Range in GuestNetwork, It has in Legacy Interface #909

Open hstan77 opened 3 years ago

hstan77 commented 3 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

In Legacy Interface , GuestNetwork Range can be add : Infrastructure -> zone -> physical network ->Guest Network-> Guest IP range and there is link of "Add IP Range" in top right to add IP Range

However in Primate , there is no such function, after guest network added, there is no place view the range (especially the start and end ip )

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

rohityadavcloud commented 3 years ago

@hstan77 do you mean public IP range? There's no such thing as guest IP range in legacy UI as well. In new UI, it's under same path but the difference is that the information is laid out in tabs of different traffic types.

hstan77 commented 3 years ago

Hi @rhtyd

In Legacy interface, go to:

Infrastructure > ZonesAdvSG > Physical Network > GuestNet > "Click View IP Range"

And can add / IP there.

If go to Navigation > Guest Network , there is no such function of View IP range and add IP, but browse through Infrastructure zone Physical Network, there is the function there.

This function is useful , especially for Advance WIth SG, where Public IP is the GuestNetwork. For example, when define Network, with x.x.x.x/24 and wish to change / add start and end IP. Also it need to add new prefix where all is in the same VLAN.

davidjumani commented 3 years ago

@hstan77 Do you mean this ?

Screenshot from 2021-01-04 09-51-46

@rhtyd I can look into this

hstan77 commented 3 years ago

Yes, that's right .

Over here, we can see the start end ip that we entered during setup network . Although cannot edit, but can add new IP to it.

Without this, if there is new prefix added to the same VLAN, admin have to setup another GuestNetwork, which eventually reflect as new NIC card to VM

Another scenario that needs this is , for eg, the prefix 90.90.90.0/24 , initially allocated start-end of 90.90.90.10 - 90.90.90.100 (for example), but after that need to add additional IP (for example 90.90.90.101 to 200 ), it not possible to do.

On Mon, Jan 4, 2021 at 12:25 PM davidjumani notifications@github.com wrote:

@hstan77 https://github.com/hstan77 Do you mean this ?

[image: Screenshot from 2021-01-04 09-51-46] https://user-images.githubusercontent.com/8244774/103501017-f646b780-4e72-11eb-9177-f31d1d3dd0d0.png

@rhtyd https://github.com/rhtyd I can look into this

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache/cloudstack-primate/issues/909#issuecomment-753749118, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFNGARYJHNGQDT4OPEOEE3SYE7NBANCNFSM4VP6IPUQ .

-- Regards, Hean Seng

rohityadavcloud commented 3 years ago

Thanks for explaining @hstan77 this looks like security groups only feature that isn't supported in new UI, you can use legacy UI or API for the use-case until we address this. Since this is infra-related feature accessible only to the root admin it may not be considered a blocker cc @DaanHoogland (you agree?)

@davidjumani since you've already started a PR, let me give you some pointers -- for SG the guest network uses the public IPs, where the IP range is consumed directly by the end VMs than a virtual network; we probably want to add a tab in the guest networks (SG guest networks only) which are treated as shared network with vlan ip/ranges. This tab should list the range with pagination, for ex:

command: listVlanIpRanges
zoneid: f4bca7d3-81ce-4bfe-9c50-56acf057844b
networkid: 8932951f-4ea2-49e2-9c83-65c16ef4fd04
page: 1
pagesize: 20
response: json

On top of the tab we can give a button to open a modal/form that takes input to create new range, for example: (note, the parameter forVirtualNetwork is false)

command: createVlanIpRange
forVirtualNetwork: false
networkid: 8932951f-4ea2-49e2-9c83-65c16ef4fd04
gateway: 192.168.1.1
netmask: 255.255.255.0
startip: 192.168.1.100
endip: 192.168.1.200
response: json

@davidjumani the tab should check if the APIs are available to the logged-in user/account (createVlanIpRange and listVlanIpRanges)

hstan77 commented 3 years ago

Yes, can still use old UI or API,

In legacy UI interface, there is only add, but not edit. However, I may suggest allow edit for the start and end IP (instead of add new) , or add new range for new prefix .

For modification, i also suggest to allow edit to add in IPv6 if possible to the range. As growing support and demand of IPv6 in real world now, many old implementation that now may start adding IPv6 to the pool.. But those IPv4 Prefix that previously added is not able to edit for IPv6 address, although in the DB table it has the colum ready , but UI doesn not allow to edit.

On Mon, Jan 4, 2021 at 3:28 PM Rohit Yadav notifications@github.com wrote:

Thanks for explaining @hstan77 https://github.com/hstan77 this looks like security groups only feature that isn't supported in new UI, you can use legacy UI or API for the use-case until we address this. Since this is infra-related feature accessible only to the root admin it may not be considered a blocker cc @DaanHoogland https://github.com/DaanHoogland (you agree?)

@davidjumani https://github.com/davidjumani since you've already started a PR, let me give you some pointers -- for SG the guest network is uses the public network, where the IP range is consumed directly by the end VMs than a virtual network; we probably want to add a tab in the guest networks (SG guest networks only) which are treated as shared network with vlan ip/ranges. This tab should list the range with pagination, for ex:

command: listVlanIpRanges zoneid: f4bca7d3-81ce-4bfe-9c50-56acf057844b networkid: 8932951f-4ea2-49e2-9c83-65c16ef4fd04 page: 1 pagesize: 20 response: json

On top of the tab we can give a button to open a modal/form that takes input to create new range, for example: (note, the parameter forVirtualNetwork is false)

command: createVlanIpRange forVirtualNetwork: false networkid: 8932951f-4ea2-49e2-9c83-65c16ef4fd04 gateway: 192.168.1.1 netmask: 255.255.255.0 startip: 192.168.1.100 endip: 192.168.1.200 response: json

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache/cloudstack-primate/issues/909#issuecomment-753807269, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFNGAVTDNBNM3RPN7JSQL3SYFUYPANCNFSM4VP6IPUQ .

-- Regards, Hean Seng