apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
1.89k stars 1.08k forks source link

add domain path to all entities #8086

Open DaanHoogland opened 9 months ago

DaanHoogland commented 9 months ago
ISSUE TYPE
COMPONENT NAME
CLOUDSTACK VERSION
CONFIGURATION
OS / ENVIRONMENT
SUMMARY

as agreed in https://github.com/apache/cloudstack/pull/7386#issuecomment-1759616648, we need to make the enhancement by @pierrelefevre more generic.

STEPS TO REPRODUCE
EXPECTED RESULTS
localcloud) 🐱 > list networks filter=name,type,domainpath
{
  "count": 2,
  "network": [
    {
      "domainpath": "ROOT",
      "name": "bla",
      "type": "Isolated"
    },
    {
      "domainpath": "ROOT",
      "name": "sla",
      "type": "Shared"
    }
  ]
}
ACTUAL RESULTS
localcloud) 🐱 > list networks filter=name,type,domainpath
{
  "count": 2,
  "network": [
    {
      "name": "bla",
      "type": "Isolated"
    },
    {
      "domainpath": "ROOT",
      "name": "sla",
      "type": "Shared"
    }
  ]
}
rohityadavcloud commented 1 month ago

@DaanHoogland is the fix required that we always send the domain path for all networks? Concern - could it slow down listing networks at scale?

DaanHoogland commented 1 month ago

@DaanHoogland is the fix required that we always send the domain path for all networks? Concern - could it slow down listing networks at scale?

@rohityadavcloud , we could think of making this an option on the call, if it really is a performance hog. I have not considdered that, just the automation consequence as described by the refenced PR (comment) and the original issue #7363. I am not sure but I think the issue was with automation using terraform.

rohityadavcloud commented 1 month ago

Thanks @DaanHoogland let me figure out and raise a PR. (related - the list networks API right now, works by listing all networks and then return a page out of it - pagination isn't implemented in it properly; likely @abh1sar 's PR may fix it)