apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2k stars 1.09k forks source link

[WIP] Add vm instance id to volume usage record #9217

Open sureshanaparti opened 3 months ago

sureshanaparti commented 3 months ago

Description

This PR adds vm instance id to volume usage record, addresses #7399

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

github-actions[bot] commented 3 months ago

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 15.32%. Comparing base (acae5c5) to head (0ca37b4). Report is 75 commits behind head on 4.19.

:exclamation: Current head 0ca37b4 differs from pull request most recent head 92e72f1

Please upload reports for the commit 92e72f1 to get more accurate results.

Files Patch % Lines
...ma/src/main/java/com/cloud/event/UsageEventVO.java 0.00% 14 Missing :warning:
...java/com/cloud/usage/parser/VolumeUsageParser.java 0.00% 7 Missing :warning:
...a/src/main/java/com/cloud/usage/UsageVolumeVO.java 0.00% 3 Missing :warning:
...rc/main/java/com/cloud/usage/UsageManagerImpl.java 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9217 +/- ## ============================================ + Coverage 14.96% 15.32% +0.35% - Complexity 11002 11652 +650 ============================================ Files 5373 5452 +79 Lines 469309 476576 +7267 Branches 58607 58211 -396 ============================================ + Hits 70231 73014 +2783 - Misses 391304 395494 +4190 - Partials 7774 8068 +294 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9217/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9217/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.20% <ø> (-0.10%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9217/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.07% <6.89%> (+0.39%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.