Closed vishesh92 closed 2 weeks ago
@blueorangutan package
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 14.96%. Comparing base (
edf7394
) to head (7cd62ca
). Report is 10 commits behind head on 4.19.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9885
@blueorangutan test
@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
clgtm, not sure though if it makes sense to change the version globally this way instead of in the marvin setup.
We are changing only for marvin here. I am not sure if changing this globally will break some other stuff or not.
[SF] Trillian test result (tid-10418) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42973 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9230-t10418-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File |
---|---|---|---|
test_02_trigger_shutdown | Failure |
341.74 | test_safe_shutdown.py |
Description
Fixes #7927
We replace the first occurence of
-
with+
to make the marvin version PEP440 compliantTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
For testing, use pip version 24.0. Able to reproduce the bug mentioned in the link with this version of pip.
How did you try to break this feature and the system with this change?