vxlan: do not create duplicated network for private gateway

weizhouapache commented 3 weeks ago

Description

This PR fixes #7891

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache commented 3 weeks ago

@blueorangutan package

blueorangutan commented 3 weeks ago

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.96%. Comparing base (1577218) to head (0ecf105). Report is 9 commits behind head on 4.19.

Files	Patch %	Lines
.../com/cloud/network/guru/VxlanGuestNetworkGuru.java	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9232 +/- ## ============================================ - Coverage 14.96% 14.96% -0.01% - Complexity 11002 11003 +1 ============================================ Files 5373 5377 +4 Lines 469315 469465 +150 Branches 59847 61125 +1278 ============================================ + Hits 70233 70247 +14 - Misses 391309 391440 +131 - Partials 7773 7778 +5 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9232/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9232/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9232/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.67% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 3 weeks ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9895

weizhouapache commented 3 weeks ago

@blueorangutan test rocky8 kvm-rocky8

blueorangutan commented 3 weeks ago

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan commented 2 weeks ago

[SF] Trillian test result (tid-10423) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44939 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9232-t10423-kvm-rocky8.zip Smoke tests completed. 131 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

apache / cloudstack