apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
1.83k stars 1.07k forks source link

Add action button to enable/disable Oauth provider #9242

Closed abh1sar closed 2 weeks ago

abh1sar commented 2 weeks ago

Description

Fixes: https://github.com/apache/cloudstack/issues/8501

  1. Action button to enable/disable Oauth2 provider
  2. Trim extra spaces from clientid, uri and secretkey

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

Screenshot from 2024-06-13 14-02-12 Screenshot from 2024-06-13 14-02-24 Screenshot from 2024-06-13 14-02-46 Screenshot from 2024-06-13 14-02-57

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 14.95%. Comparing base (b2ef53b) to head (b24e990). Report is 16 commits behind head on 4.19.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9242 +/- ## ============================================ - Coverage 14.96% 14.95% -0.01% + Complexity 11013 11011 -2 ============================================ Files 5377 5378 +1 Lines 469567 469808 +241 Branches 60162 58662 -1500 ============================================ - Hits 70285 70279 -6 - Misses 391498 391745 +247 Partials 7784 7784 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9242/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9242/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9242/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.67% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rohityadavcloud commented 2 weeks ago

LGTM @blueorangutan ui

blueorangutan commented 2 weeks ago

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented 2 weeks ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9242 (QA-JID-377)

kiranchavala commented 2 weeks ago

@blueorangutan package

blueorangutan commented 2 weeks ago

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

abh1sar commented 2 weeks ago

@blueorangutan package

blueorangutan commented 2 weeks ago

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 2 weeks ago

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9941

blueorangutan commented 2 weeks ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9943

kiranchavala commented 2 weeks ago

@blueorangutan test

blueorangutan commented 2 weeks ago

@kiranchavala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented 2 weeks ago

[SF] Trillian test result (tid-10444) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43513 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9242-t10444-kvm-centos7.zip Smoke tests completed. 131 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File