vmware: do not tear down vm disks if deploy-as-is vm has vm snapshots

weizhouapache commented 2 weeks ago

Description

This PR fixes #9180

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache commented 2 weeks ago

@blueorangutan package

weizhouapache commented 2 weeks ago

@nvazquez @harikrishna-patnala I have no idea why the data disks are tear down when start a deploy-as-is vm. Anyway, this change seems to be working.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.96%. Comparing base (19e9020) to head (f4d95fc). Report is 2 commits behind head on 4.19.

Files	Patch %	Lines
...oud/hypervisor/vmware/resource/VmwareResource.java	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9243 +/- ## ============================================ - Coverage 14.96% 14.96% -0.01% Complexity 11015 11015 ============================================ Files 5377 5377 Lines 469605 469605 Branches 60258 58877 -1381 ============================================ - Hits 70296 70292 -4 - Misses 391523 391528 +5 + Partials 7786 7785 -1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.68% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

weizhouapache commented 2 weeks ago

@blueorangutan package

blueorangutan commented 2 weeks ago

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 2 weeks ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9924

weizhouapache commented 2 weeks ago

Thanks @harikrishna-patnala @nvazquez

@blueorangutan test rocky8 vmware-80

blueorangutan commented 2 weeks ago

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

blueorangutan commented 2 weeks ago

[SF] Trillian Build Failed (tid-10434)

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Failure`	139.48	test_cluster_drs.py
test_01_create_lb_rule_src_nat	`Error`	118.97	test_loadbalance.py
test_02_create_lb_rule_non_nat	`Error`	223.67	test_loadbalance.py
test_02_create_lb_rule_non_nat	`Error`	223.68	test_loadbalance.py
test_assign_and_removal_lb	`Error`	0.12	test_loadbalance.py
test_01_redundant_vpc_site2site_vpn	`Error`	628.24	test_vpc_vpn.py

apache / cloudstack