veeam: fix issues with PreSetup and DVS and Solidfire

weizhouapache commented 2 weeks ago

Description

This PR fixes some issues when restore veeam backup (including #8939)

The storage pool uses PreSetup or VMFS
The backend use DVS, not standard virtual switch
The storage pool use Solidfire storage

It has been tested

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache commented 2 weeks ago

@blueorangutan package

blueorangutan commented 2 weeks ago

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0.96154% with 103 lines in your changes missing coverage. Please review.

Project coverage is 14.95%. Comparing base (ed86dc9) to head (a97a0ed). Report is 1 commits behind head on 4.19.

Files	Patch %	Lines
...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java	0.00%	91 Missing :warning:
.../storage/datastore/db/PrimaryDataStoreDaoImpl.java	0.00%	7 Missing :warning:
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java	16.66%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9256 +/- ## ============================================ - Coverage 14.95% 14.95% -0.01% - Complexity 11012 11014 +2 ============================================ Files 5378 5378 Lines 469937 470018 +81 Branches 58465 58265 -200 ============================================ + Hits 70282 70292 +10 - Misses 391870 391940 +70 - Partials 7785 7786 +1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9256/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.66% <0.96%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 2 weeks ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9952

weizhouapache commented 2 weeks ago

@blueorangutan test rocky8 vmware-80

blueorangutan commented 2 weeks ago

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

weizhouapache commented 2 weeks ago

@blueorangutan test rocky8 vmware-80

blueorangutan commented 2 weeks ago

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

blueorangutan commented 2 weeks ago

[SF] Trillian test result (tid-10480) Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8 Total time taken: 46462 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9256-t10480-vmware-80.zip Smoke tests completed. 126 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	103.18	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	43.04	test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	39.46	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.10	test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity	`Failure`	143.33	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	100.38	test_nonstrict_affinity_group.py
test_02_trigger_shutdown	`Failure`	341.58	test_safe_shutdown.py

sureshanaparti commented 1 week ago

@blueorangutan test rocky8 vmware-80

blueorangutan commented 1 week ago

@sureshanaparti a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

blueorangutan commented 1 week ago

[SF] Trillian test result (tid-10621) Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47925 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9256-t10621-vmware-80.zip Smoke tests completed. 131 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

apache / cloudstack