[linstor] Fix revertSnapshot

[wornet-mwo]

Description

revertSnapshot uses currently the UUID instead of the path, which defines the resource group on linstor and is set matching to the path when creating a snapshot. This PR just replaces the UUID by path of a snapshot.

This PR is done against 4.19 as 4.18 has been refactored in between.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [X] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [X] Major
• [ ] Minor
• [ ] Trivial

How Has This Been Tested?

• linstor cluster running on same nodes as KVM-Hosts used for ACS.
• Ubuntu 22.04, compiled 4.19 as package, used a non productive cluster to test
• Previous situation: create volume snapshot, create a file in running instance, shutdown instance, try to restore via GUI: Failure as volume cannot be found (which happens if volume has not been initially created in linstor)
• Fixed sitation: same actions, but restore works and disk is verified in state of snapshot after starting instance.

[boring-cyborg[bot]]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions. Apache CloudStack is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/

[rp-]

clgtm Tested with Linstor only storage.

Thanks for finding and fixing this.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.28%. Comparing base (81269ad) to head (cbcdb78). Report is 3 commits behind head on 4.19.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9271 +/- ## ============================================ - Coverage 14.95% 4.28% -10.67% ============================================ Files 5382 363 -5019 Lines 470080 29393 -440687 Branches 58506 5139 -53367 ============================================ - Hits 70293 1260 -69033 + Misses 392001 27990 -364011 + Partials 7786 143 -7643 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9271/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10027

[boring-cyborg[bot]]

Awesome work, congrats on your first merged pull request!