set isSystem for SVM IPs

apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform

https://cloudstack.apache.org/

Apache License 2.0

1.83k stars 1.07k forks source link

set isSystem for SVM IPs #9281

Closed DaanHoogland closed 1 week ago

DaanHoogland commented 1 week ago

Description

This PR

Fixes: #9275

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[x] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[x] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache commented 1 week ago

thanks @DaanHoogland for your investigation it is great you found the root cause !

I did a quick search on the code, it looks like the issue is caused by

https://github.com/apache/cloudstack/blob/8806e44e4fb9cc41460ed5cf0ab319be2b018b54/server/src/main/java/com/cloud/network/guru/PublicNetworkGuru.java#L132

(the parameter false may should be forSystemVms)

DaanHoogland commented 1 week ago

forSystemVms

thanks @weizhouapache that does sound like a much better and more generic place to make sure the flag is set. I'll revert my changes here and apply your suggestion.

DaanHoogland commented 1 week ago

@blueorangutan package