apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
1.83k stars 1.07k forks source link

fix AssignToLoadBalancerRule input param #9287

Closed nimabm closed 4 days ago

nimabm commented 1 week ago

changed vmidipmap[0].ip to vmidipmap[0].vmip

Description

the AssignToLoadBalancerRule has vmidipmap[0].vmip as input but in the description mentioned vmidipmap[0].ip incrrectly.

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

boring-cyborg[bot] commented 1 week ago

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 29.38312% with 435 lines in your changes missing coverage. Please review.

Project coverage is 15.42%. Comparing base (7dce3d8) to head (2af27e9). Report is 40 commits behind head on 4.19.

Files Patch % Lines
agent/src/main/java/com/cloud/agent/Agent.java 0.00% 81 Missing :warning:
...ommand/admin/network/CreateNetworkOfferingCmd.java 0.00% 50 Missing :warning:
...nt/resource/consoleproxy/ConsoleProxyResource.java 0.00% 41 Missing :warning:
...ck/api/command/admin/vpc/CreateVPCOfferingCmd.java 11.62% 35 Missing and 3 partials :warning:
...in/java/com/cloud/agent/api/storage/OVFHelper.java 10.71% 24 Missing and 1 partial :warning:
...gent/src/main/java/com/cloud/agent/AgentShell.java 9.09% 20 Missing :warning:
api/src/main/java/com/cloud/storage/Storage.java 68.33% 16 Missing and 3 partials :warning:
...src/main/java/com/cloud/hypervisor/Hypervisor.java 66.66% 16 Missing and 2 partials :warning:
...pi/src/main/java/com/cloud/agent/api/to/NicTO.java 0.00% 12 Missing :warning:
.../main/java/com/cloud/deploy/DeploymentPlanner.java 7.69% 12 Missing :warning:
... and 47 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9287 +/- ## ============================================ + Coverage 14.95% 15.42% +0.46% - Complexity 11013 11808 +795 ============================================ Files 5382 5469 +87 Lines 470092 478292 +8200 Branches 57685 60785 +3100 ============================================ + Hits 70311 73768 +3457 - Misses 391993 396397 +4404 - Partials 7788 8127 +339 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9287/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.18% <ø> (-0.10%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.18% <29.38%> (+0.51%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vishesh92 commented 4 days ago

@blueorangutan package

blueorangutan commented 4 days ago

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

vishesh92 commented 4 days ago

@nimabm Can you rebase your PR against 4.19 or 4.18 and change the base branch in the PR?

sureshanaparti commented 4 days ago

Hi @nimabm Only API parameter description change here, seems good to go in 4.19.1. Can you rebase with 4.18 / 4.19 branch and change the target branch?

blueorangutan commented 4 days ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10159

nimabm commented 4 days ago

@vishesh92 @sureshanaparti has been changed to 4.19

github-actions[bot] commented 4 days ago

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

nimabm commented 4 days ago

New PR https://github.com/apache/cloudstack/pull/9306