Closed nimabm closed 4 days ago
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:
Attention: Patch coverage is 29.38312%
with 435 lines
in your changes missing coverage. Please review.
Project coverage is 15.42%. Comparing base (
7dce3d8
) to head (2af27e9
). Report is 40 commits behind head on 4.19.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan package
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
@nimabm Can you rebase your PR against 4.19 or 4.18 and change the base branch in the PR?
Hi @nimabm Only API parameter description change here, seems good to go in 4.19.1. Can you rebase with 4.18 / 4.19 branch and change the target branch?
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10159
@vishesh92 @sureshanaparti has been changed to 4.19
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
changed vmidipmap[0].ip to vmidipmap[0].vmip
Description
the AssignToLoadBalancerRule has vmidipmap[0].vmip as input but in the description mentioned vmidipmap[0].ip incrrectly.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?