UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page

sureshanaparti commented 3 months ago

Description

This PR fixes action buttons view when public IP address is selected, in Network -> Public IP addresses page

Fixes #8106

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

Before Fix =>

After Fix =>

How Has This Been Tested?

Accessed Network -> Public IP addresses page in UI, and selected public IP address & checked the action buttons.

How did you try to break this feature and the system with this change?

sureshanaparti commented 3 months ago

@blueorangutan ui

blueorangutan commented 3 months ago

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 14.98%. Comparing base (0b857de) to head (73173fe). Report is 149 commits behind head on 4.19.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9288 +/- ## ============================================= - Coverage 30.70% 14.98% -15.72% + Complexity 34232 11051 -23181 ============================================= Files 5376 5389 +13 Lines 378222 470581 +92359 Branches 55053 60932 +5879 ============================================= - Hits 116135 70528 -45607 - Misses 246719 392216 +145497 + Partials 15368 7837 -7531 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/9288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (-0.04%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.70% <ø> (-0.96%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 3 months ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9288 (QA-JID-385)

sureshanaparti commented 3 months ago

@blueorangutan ui

blueorangutan commented 3 months ago

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented 3 months ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9288 (QA-JID-387)

sureshanaparti commented 3 months ago

While the Public IP view looks okay now, other views may not be looking the same

Got it, thanks for testing @shwstppr

apache / cloudstack