Let network guru decide if ipv6 cidr size can't be equal to 64

vishesh92 commented 3 months ago

Description

This PR makes changes to allow shared networks to have ipv6 cidr size other than 64. For now, it let's network guru decide whether this is possible or not. Network Orchestrator relies on the return value of isSlaacV6Only method of the network guru.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache commented 3 months ago

@blueorangutan package

blueorangutan commented 3 months ago

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 14.95%. Comparing base (083ac06) to head (12f0393). Report is 15 commits behind head on 4.19.

Files	Patch %	Lines
...tack/engine/orchestration/NetworkOrchestrator.java	0.00%	5 Missing :warning:
.../cloud/configuration/ConfigurationManagerImpl.java	20.00%	3 Missing and 1 partial :warning:
.../main/java/com/cloud/network/guru/NetworkGuru.java	0.00%	3 Missing :warning:
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9289 +/- ## ============================================ + Coverage 4.28% 14.95% +10.66% - Complexity 0 11008 +11008 ============================================ Files 363 5383 +5020 Lines 29393 470200 +440807 Branches 5139 57734 +52595 ============================================ + Hits 1260 70308 +69048 - Misses 27990 392104 +364114 - Partials 143 7788 +7645 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.66% <17.64%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 3 months ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10093

weizhouapache commented 3 months ago

@blueorangutan test

blueorangutan commented 3 months ago

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov commented 3 months ago

@blueorangutan test matrix

blueorangutan commented 3 months ago

@borisstoyanov a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan commented 3 months ago

[SF] Trillian test result (tid-10584) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42214 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9289-t10584-kvm-centos7.zip Smoke tests completed. 131 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan commented 3 months ago

[SF] Trillian test result (tid-10587) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43060 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9289-t10587-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	`Error`	43.99	test_vm_life_cycle.py

blueorangutan commented 3 months ago

[SF] Trillian test result (tid-10585) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60923 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9289-t10585-xenserver-71.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Error`	3578.86	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Error`	0.08	test_cluster_drs.py
ContextSuite context=TestClusterDRS>:teardown	`Error`	1.15	test_cluster_drs.py
test_17_retrieve_cpvm_default_files	`Error`	937.58	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Error`	2.13	test_diagnostics.py

blueorangutan commented 3 months ago

[SF] Trillian test result (tid-10586) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 74333 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9289-t10586-vmware-67u3.zip Smoke tests completed. 127 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_list_system_vms_metrics_history	`Failure`	0.29	test_metrics_api.py
test_01_restore_vm	`Error`	3607.36	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	3626.07	test_restore_vm.py
test_01_deploy_vm_on_specific_host	`Error`	18.90	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3606.70	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	4.49	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	4.46	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	13.73	test_vm_deployment_planner.py

apache / cloudstack