search

apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2k stars 1.09k forks source link

UI: Remove the delete action item for cks nodes #9293

Closed kiranchavala closed 2 months ago

kiranchavala commented 3 months ago

ISSUE TYPE

Improvement issue

COMPONENT NAME

Component: UI

CLOUDSTACK VERSION

Cloudstack version 4.19.0

SUMMARY

Remove the delete action item for kubernetes nodes inside a cks cluster

Steps to reproduce the issue

  1. Create cks cluster and navigate inside the cks cluster

Remove the delete action item

Currently, we are throwing a exception whenever a user tries to delete the kubernetes node based on this

https://github.com/apache/cloudstack/pull/9057

In my opinion its better not to show the delete icon , when the operation is expected to fail,

End user should be only allowed to delete the cks cluster from the UI

Expected behaviour

Remove the delete action item for the cks nodes

Pearl1594 commented 3 months ago

@kiranchavala I believe the PR #9057 prevents deletion of the CKS nodes using the destroyVirtualMachine API from the instances tab. These delete icons basically translate to scaleKubernetesCluster which effectively scales down a specific node in the CKS cluster

DaanHoogland commented 3 months ago

@Pearl1594 , you are saying it is solved in #9057 ?

rohityadavcloud commented 2 months ago

Fixed by https://github.com/apache/cloudstack/pull/9434