apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
1.83k stars 1.07k forks source link

Fix AssignToLoadBalancerRule input param #9306

Closed nimabm closed 4 days ago

nimabm commented 4 days ago

changed vmidipmap[0].ip to vmidipmap[0].vmip

Description

This PR the AssignToLoadBalancerRule has vmidipmap[0].vmip as input but in the description mentioned vmidipmap[0].ip incrrectly.

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 14.97%. Comparing base (53faf0f) to head (3b9e90a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9306 +/- ## ============================================ - Coverage 14.97% 14.97% -0.01% + Complexity 11049 11048 -1 ============================================ Files 5390 5390 Lines 470964 470964 Branches 59210 60607 +1397 ============================================ - Hits 70528 70518 -10 - Misses 392599 392611 +12 + Partials 7837 7835 -2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9306/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.68% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sureshanaparti commented 4 days ago

@blueorangutan package

blueorangutan commented 4 days ago

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 4 days ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10168

boring-cyborg[bot] commented 4 days ago

Awesome work, congrats on your first merged pull request!