Revert listAll behaviour for templates & iso

vishesh92 commented 3 days ago

Description

Reverts https://github.com/apache/cloudstack/pull/9064/ . Also reverts the changes done in #9300. And UI changes from this PR https://github.com/apache/cloudstack/pull/9196.

adding listall=true with templatefilter=self is returning templates with account system as well.

(mycloud) __ > list templates templatefilter=self filter=name,account
(mycloud) __ > list templates templatefilter=self filter=name,account listall=true 
{
  "count": 1,
  "template": [
    {
      "account": "system",
      "name": "SystemVM Template (KVM)"
    }
  ]
}

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti commented 3 days ago

@blueorangutan package

blueorangutan commented 3 days ago

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.27%. Comparing base (46f6725) to head (be6078a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9309 +/- ## ============================================ - Coverage 15.01% 4.27% -10.74% ============================================ Files 5393 364 -5029 Lines 471455 29441 -442014 Branches 59447 5148 -54299 ============================================ - Hits 70787 1260 -69527 + Misses 392781 28038 -364743 + Partials 7887 143 -7744 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9309/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sureshanaparti commented 3 days ago

@blueorangutan package

blueorangutan commented 3 days ago

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 3 days ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10186

sureshanaparti commented 3 days ago

Verified the listing templates behavior.

(testenv)  > list templates templatefilter=self filter=name,account
(testenv)  > 
(testenv)  > list templates templatefilter=self filter=name,account listall=true 
(testenv)  >

with self template:

(testenv)  > list templates templatefilter=self filter=name,account
{
  "count": 1,
  "template": [
    {
      "account": "admin",
      "name": "CentOS7"
    }
  ]
}
(testenv)  > 
(testenv)  > list templates templatefilter=self filter=name,account listall=true 
{
  "count": 1,
  "template": [
    {
      "account": "admin",
      "name": "CentOS7"
    }
  ]
}
(testenv)  >

sureshanaparti commented 3 days ago

Merging this, as the change in listall behavior earlier resulting in test failures.

apache / cloudstack