Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver

sureshanaparti commented 3 days ago

Description

This PR fixes src datastore on copy check for PowerFlex/ScaleIO storage driver.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested volume migration from pool NFS -> PowerFlex and PowerFlex -> PowerFlex. NFS -> PowerFlex fails with not suitable error.

How did you try to break this feature and the system with this change?

sureshanaparti commented 3 days ago

@blueorangutan package

blueorangutan commented 3 days ago

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.24%. Comparing base (6b25ed7) to head (36356cd).

Files	Patch %	Lines
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.18 #9310 +/- ## ============================================ - Coverage 12.24% 12.24% -0.01% + Complexity 9296 9294 -2 ============================================ Files 4699 4699 Lines 414339 414339 Branches 53023 53311 +288 ============================================ - Hits 50731 50727 -4 - Misses 357303 357308 +5 + Partials 6305 6304 -1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9310/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `12.24% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 3 days ago

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10187

apache / cloudstack