search

apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
1.98k stars 1.09k forks source link

secstorage.nfs.version is not used in two scenarios #9469

Open weizhouapache opened 1 month ago

weizhouapache commented 1 month ago

the NFS version is not considered in two scenarios

https://github.com/apache/cloudstack/blob/7214c13e106368127c928b2028c80c3bacaf528c/engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java#L87

https://github.com/apache/cloudstack/blob/7214c13e106368127c928b2028c80c3bacaf528c/engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java#L436-L437

https://github.com/apache/cloudstack/blob/7214c13e106368127c928b2028c80c3bacaf528c/server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java#L479-L481

the nfs version is set to null

ISSUE TYPE
COMPONENT NAME
CLOUDSTACK VERSION
CONFIGURATION
OS / ENVIRONMENT
SUMMARY
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS
Revellski commented 1 month ago

We can also not mount CD ISO to instances unless the NFS server explicitly supports NFSv3. This is with secstorage.nfs.version being set to 4.0 and 4.1. 

Cloudstack 4.19.1.0
SSVM 4.19.1.0
Hypervisor XenServer
weizhouapache commented 1 month ago

We can also not mount CD ISO to instances unless the NFS server explicitly supports NFSv3. This is with secstorage.nfs.version being set to 4.0 and 4.1.

Cloudstack 4.19.1.0
SSVM 4.19.1.0
Hypervisor XenServer

that's good point @Revellski , thanks

we need to review all the operations which mount secondary storage on hosts or management servers, including

DaanHoogland commented 1 month ago

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

DaanHoogland commented 1 month ago

also editting labels at the same time seems to clash :)

JoaoJandre commented 1 month ago

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

@DaanHoogland Yeah, this makes sense. Also, I took some time to realize we where editing the issues' labels/milestones at the same time xD.

shwstppr commented 3 weeks ago

@weizhouapache I've created #9559 for the original issues. Regarding https://github.com/apache/cloudstack/issues/9469#issuecomment-2260390777, do we any time mount ISOs on the hypervisor hosts?

weizhouapache commented 3 weeks ago

hm, I think this happened a few times now @JoaoJandre , me changing the setting of the milestone after you have, sorry. I think we can add fixes to 4.19 and merge forward, whereas enhancements should go in 4.20 directly, agree?

@DaanHoogland Yeah, this makes sense. Also, I took some time to realize we where editing the issues' labels/milestones at the same time xD.

I think there might be several checks , for example