apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2k stars 1.09k forks source link

UI sorting of elements not working on some views #9595

Closed rohityadavcloud closed 3 weeks ago

rohityadavcloud commented 1 month ago

As a root admin, I cannot change sort order of some views such as:

Screenshot 2024-08-27 at 4 45 53 PM

In addition, I think the following resources should also allow sorting/ordering by the root admin:

ISSUE TYPE
COMPONENT NAME
UI, API
CLOUDSTACK VERSION
4.19.1.1
CONFIGURATION

Adv zone + KVM

DaanHoogland commented 1 month ago

@rohityadavcloud , unless you think this is a regression it seems like an enhancement to me, I marked it for 4.21 for now, please let me know if you disagree.

DaanHoogland commented 1 month ago

this is indeed a regression in comparison to 4.18. It also seems like redundant functionality as (in the UI) sort can be done on several columns. I can see in the simplest , two-row case the columns are being updated in the DB and will look into what happens in more complex situations.

DaanHoogland commented 1 month ago

gotten too the reason in code, need to think of a solution. The fetching is a two step process, first grab the IDs (ordering applied), than use the IDs to fetch the records (ordering totally forgotten about) /me thinking about a way to preserve the ordering.

DaanHoogland commented 3 weeks ago

@rohityadavcloud #9624 solves the backwards compatibility for service and disk offering, can you test please? I did not reproduce it for network and vpc offerings. It also fixes an extra issue to contain the sorting to the current page in the UI (thanks @vishesh92 )

DaanHoogland commented 3 weeks ago

fixed in #9624