engine-orchestration: fix issue for empty product in vm metadata

Description

Fixes #9607

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr should we still have a fallback in the agent code, like in https://github.com/apache/cloudstack/pull/9608 ?

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.57%. Comparing base (a5f5560) to head (1e37121). Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java	50.00%	0 Missing and 2 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9610 +/- ## =========================================== Coverage 15.57% 15.57% - Complexity 12047 12049 +2 =========================================== Files 5505 5505 Lines 482621 482625 +4 Branches 61174 59105 -2069 =========================================== + Hits 75176 75185 +9 + Misses 399141 399134 -7 - Partials 8304 8306 +2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9610/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.16% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.35% <60.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@shwstppr should we still have a fallback in the agent code, like in #9608 ?

Ideally, it shouldn't be needed but it won't harm. Should that be done for both manufacturer and product? @rohityadavcloud

@shwstppr should we still have a fallback in the agent code, like in #9608 ?

Ideally, it shouldn't be needed but it won't harm. Should that be done for both manufacturer and product? @rohityadavcloud

will there be a situation conceivable where an empty product or manufacturer is possible? if not a fallback is nice.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10885

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11271) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51671 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9610-t11271-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_VPC_default_routes	`Failure`	198.14	test_vpc_router_nics.py

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10901

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian Build Failed (tid-11280)

@blueorangutan LLtest keepEnv

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[LL] Trillian Build Failed (tid-7000)

tested in the lab:

  <sysinfo type='smbios'>
    <system>
      <entry name='manufacturer'>Apache Software Foundation</entry>
      <entry name='product'>CloudStack KVM Hypervisor</entry>
      <entry name='uuid'>dfb2e85e-b871-4084-b83d-74d6961c3a22</entry>
    </system>
  </sysinfo>

[SF] Trillian test result (tid-11305) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52366 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9610-t11305-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	`Error`	449.49	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	399.90	test_vm_life_cycle.py

[LL]Trillian test result (tid-7001) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47519 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9610-t7001-kvm-rocky8.zip Smoke tests completed. 137 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	0.00	test_kubernetes_clusters.py
test_04_nonsecured_to_secured_vm_migration	`Error`	248.38	test_vm_life_cycle.py

apache / cloudstack