Closed gpordeus closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 15.57%. Comparing base (
d7ca05e
) to head (a8f1503
). Report is 24 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan ui
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9616 (QA-JID-437)
Code LGTM. I guess this should be done for other forms too
most probably, but I think we can merge this (and create an issue for the rest or a discussion to do the inventarisation)
Description
This PR adds the
details: min
parameter tolistDomains
API call. Since they are used only for ids and names, more details are unnecessary andlistDomains
ends up taking a long time to execute when many domains exist.In a test environment with 5000 domains, running
time cmk listDomains
yieldedcmk listDomains 0,31s user 0,11s system 1% cpu 31,200 total
, buttime cmk listDomains details=min
yieldedcmk listDomains details=min 0,14s user 0,04s system 7% cpu 2,521 total
.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
I set up an environment with 5000 domains and unlimited page size.
I then checked the Network tab on the browser before and after the changes (see Screenshots).
Searching itself worked normally.