apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.1k stars 1.11k forks source link

linstor: update java-linstor dependency to 0.5.2 #9632

Closed rp- closed 2 months ago

rp- commented 2 months ago

Description

This updates the external java-linstor api library dependency. 0.5.1 had a bug while retrieving the bestErrorMessage for an apicall answer.

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested with a Linstor cluster

How did you try to break this feature and the system with this change?

rohityadavcloud commented 2 months ago

@blueorangutan package

blueorangutan commented 2 months ago

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 2 months ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10948

rohityadavcloud commented 2 months ago

Given changes only affect Linstor plugin, we cannot test - we rely on @rp- 's own testing as its maintainer.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.08%. Comparing base (a851ee3) to head (805e8a9). Report is 1 commits behind head on 4.19.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9632 +/- ## ============================================ - Coverage 15.08% 15.08% -0.01% Complexity 11188 11188 ============================================ Files 5406 5406 Lines 473186 473186 Branches 60805 60101 -704 ============================================ - Hits 71393 71391 -2 - Misses 393846 393849 +3 + Partials 7947 7946 -1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9632/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.80% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.