UI: Fix starting VMs through group action by non-root-admin users

bernardodemarco commented 2 months ago

Description

When non-root-admin users try to start multiple virtual machines, the form does not provide options to cancel or confirm the operation.

This PR fixes this bug.

Fixes #9651

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

Screenshots (if appropriate):

Before

![image](https://github.com/user-attachments/assets/f5d1fded-ad55-44db-a1b5-f6302db51566)

After

![image](https://github.com/user-attachments/assets/c2e5c61c-f1fa-4eae-92f8-e95184c73f8c)

How Has This Been Tested?

With a non-root-admin user, I selected the option to start multiple virtual machines, and verified that I was able to confirm and cancel the operation.
With a root admin user, I selected the option to start multiple virtual machines, and verified that the Consider Last Host field was rendered correctly.

bernardodemarco commented 2 months ago

@blueorangutan ui

blueorangutan commented 2 months ago

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.08%. Comparing base (ebaf064) to head (5f4b119). Report is 2 commits behind head on 4.19.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9652 +/- ## ============================================ - Coverage 15.08% 15.08% -0.01% + Complexity 11192 11189 -3 ============================================ Files 5406 5406 Lines 473183 473186 +3 Branches 61397 57683 -3714 ============================================ - Hits 71390 71375 -15 - Misses 393844 393864 +20 + Partials 7949 7947 -2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9652/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.80% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 2 months ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9652 (QA-JID-441)

apache / cloudstack