search

apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.11k stars 1.11k forks source link

Minor naming changes in Shared FileSystems 4.20 Feature #9675

Closed abh1sar closed 2 months ago

abh1sar commented 2 months ago

Description

This PR fixes..

  1. Change the UI tab name from Shared FIlesystem to Shared FileSystems
  2. Rename Shared FileSystem VM to Shared FileSystem Instance
  3. Remove create view table from schema-41910to42000 as it is not required.

Companion doc PR : https://github.com/apache/cloudstack-documentation/pull/435

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 15.81%. Comparing base (679ce1a) to head (51c765b). Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 7 Missing :warning:
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 4 Missing :warning:
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 2 Missing and 1 partial :warning:
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 1 Missing :warning:
...a/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java 0.00% 1 Missing :warning:
.../cloudstack/affinity/AffinityGroupServiceImpl.java 0.00% 1 Missing :warning:
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9675 +/- ## ============================================ + Coverage 15.76% 15.81% +0.05% - Complexity 12507 12554 +47 ============================================ Files 5619 5629 +10 Lines 491158 492029 +871 Branches 62973 61647 -1326 ============================================ + Hits 77419 77812 +393 - Misses 405283 405893 +610 + Partials 8456 8324 -132 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9675/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.48% <ø> (+0.42%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.60% <0.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abh1sar commented 2 months ago

@blueorangutan package

blueorangutan commented 2 months ago

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 2 months ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11104

abh1sar commented 2 months ago

@blueorangutan test

blueorangutan commented 2 months ago

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

abh1sar commented 2 months ago

@JoaoJandre @rohityadavcloud This PR contains some minor cosmetic changes related to naming conventions for the Shared FileSystems feature we are shipping in 4.20. But I think it has high impact in terms of user experience and clarity. For example,

The other small change is to just remove the user_vm_view definition from upgrade path, as we have separate files for creating views.

Can we please include this in 4.20.0?

rohityadavcloud commented 2 months ago

@abh1sar as long as this is reviewed and tested, I think it's okay but since freeze is declared - it's upto our release manager @JoaoJandre to review and approve/merge.

I like that we've dropped the unnecessary views changes as they're not kept in separate file, LGTM overall.

weizhouapache commented 2 months ago

@blueorangutan test

blueorangutan commented 2 months ago

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

borisstoyanov commented 2 months ago

@blueorangutan ui

blueorangutan commented 2 months ago

@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented 2 months ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9675 (QA-JID-446)

blueorangutan commented 2 months ago

[SF] Trillian test result (tid-11465) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 55009 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9675-t11465-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 455.63 test_vpc_vpn.py
blueorangutan commented 2 months ago

[SF] Trillian test result (tid-11466) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52358 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9675-t11466-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File